Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Align Grid with other layout components #10484

Closed
Tracked by #9914
kyledurand opened this issue Sep 14, 2023 · 1 comment
Closed
Tracked by #9914

Align Grid with other layout components #10484

kyledurand opened this issue Sep 14, 2023 · 1 comment
Assignees
@jesstelford
Labels
#gsd:36573 Polaris API Alignment no-issue-activity

Comments

@kyledurand
Copy link
Member

kyledurand commented Sep 14, 2023 •
edited
Loading

Grid was built before the layout foundations project and was scheduled for deprecation before realizing other Shopify systems will include a grid component. We need to bring it up to other layout component standards like having short hand properties for columns, and gap, not just responsive values
@kyledurand kyledurand mentioned this issue Sep 14, 2023
Closed
@kyledurand kyledurand self-assigned this Sep 14, 2023
@kyledurand kyledurand added the #gsd:36573 Polaris API Alignment label Sep 14, 2023
@jesstelford jesstelford mentioned this issue Sep 15, 2023
Merged
@jesstelford jesstelford linked a pull request Sep 15, 2023 that will close this issue
Ensure non-responsive React props are properly encapsulated when converted to CSS Custom Properties #10404
Merged
@jesstelford jesstelford removed a link to a pull request Sep 15, 2023
Ensure non-responsive React props are properly encapsulated when converted to CSS Custom Properties #10404
Merged
@jesstelford jesstelford linked a pull request Sep 15, 2023 that will close this issue
Add support for non-responsive values to Grid's gap, columns, and areas props. #10489
Closed
@kyledurand kyledurand assigned jesstelford and unassigned kyledurand Sep 15, 2023
@github-actions GitHub Actions
Copy link
Contributor

Hi! We noticed there hasn’t been activity on this issue in a while. After 30 days, it will close automatically.

If it’s still relevant, or you have updates, comment and let us know. And don’t worry, you can always re-open later if needed.

@jesstelford jesstelford reopened this Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jesstelford jesstelford

Labels
#gsd:36573 Polaris API Alignment no-issue-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for non-responsive values to Grid's gap, columns, and areas props. Shopify/polaris
2 participants
@jesstelford @kyledurand