From 81bfe73feb0abc8a87aedb15e9b3935dd33d4da9 Mon Sep 17 00:00:00 2001 From: Joe Pill Date: Mon, 8 Jan 2024 15:27:22 -0600 Subject: [PATCH 1/2] fix: change default timeout to 60s --- CHANGELOG.md | 6 ++++++ lib/shipengine/configuration.rb | 2 +- lib/shipengine/version.rb | 2 +- test/internal_client/configuration_test.rb | 2 +- 4 files changed, 9 insertions(+), 3 deletions(-) diff --git a/CHANGELOG.md b/CHANGELOG.md index 217f714..841527b 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -6,3 +6,9 @@ ### Bug Fixes * Update publish to Gem API Key ([3f9c8e5](https://github.com/ShipEngine/shipengine-ruby/commit/3f9c8e5eec8147e2fb1b38a114fa0e2ff24a5f9e)) + +## [1.0.4] + +### Changes + +* increase default timeout from 30s to 60s \ No newline at end of file diff --git a/lib/shipengine/configuration.rb b/lib/shipengine/configuration.rb index 7beec20..aaab125 100644 --- a/lib/shipengine/configuration.rb +++ b/lib/shipengine/configuration.rb @@ -8,7 +8,7 @@ def initialize(api_key:, retries: nil, timeout: nil, page_size: nil, base_url: n @api_key = api_key @base_url = base_url || Constants.base_url @retries = retries || 1 - @timeout = timeout || 30_000 + @timeout = timeout || 60_000 @page_size = page_size || 50 validate end diff --git a/lib/shipengine/version.rb b/lib/shipengine/version.rb index 900c628..31a609e 100644 --- a/lib/shipengine/version.rb +++ b/lib/shipengine/version.rb @@ -1,5 +1,5 @@ # frozen_string_literal: true module ShipEngine - VERSION = '1.0.3' + VERSION = '1.0.4' end diff --git a/test/internal_client/configuration_test.rb b/test/internal_client/configuration_test.rb index c4739c2..20515f9 100644 --- a/test/internal_client/configuration_test.rb +++ b/test/internal_client/configuration_test.rb @@ -15,7 +15,7 @@ client = ShipEngine::Client.new('foo') # the global configuration should not be mutated - assert_equal 30_000, client.configuration.timeout + assert_equal 60_000, client.configuration.timeout assert_equal 50, client.configuration.page_size end it 'the global config should not be mutated if overridden at method call time' do From 7969f004567296024975463b3ba647e8d826f8aa Mon Sep 17 00:00:00 2001 From: Joe Pill Date: Mon, 8 Jan 2024 15:28:20 -0600 Subject: [PATCH 2/2] bump version # --- Gemfile.lock | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Gemfile.lock b/Gemfile.lock index b3019c8..b7ec6e4 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,7 +1,7 @@ PATH remote: . specs: - shipengine_sdk (1.0.3) + shipengine_sdk (1.0.4) faraday (>= 1.4) faraday_middleware (>= 1.0) hashie (>= 3.4)