Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ShipEngineSDK.CreateLabelFromShipmentDetails.CustomsItem and ShipEngineSDK.Common.CustomsItem appear to be identical #56

Open
FenceDad opened this issue Nov 10, 2022 · 2 comments

Comments

@FenceDad
Copy link

The two classes are identical. I use these to pass customs information when checking rates and creating labels. Can these be consolidated into one class? Preferably ShipEngineSDK.Common.CustomsItem

@AnneOReilly
Copy link
Member

Hey there!
Thanks for the heads up on the duplication. Just so you know, we do allow community contributions to the SDK
https://github.com/ShipEngine/shipengine-dotnet#contributing

It can take us a little while to tackle issues that aren't breaking, but if you submit a PR we will look through it ASAP!

@FenceDad
Copy link
Author

@AnneOReilly I see that in the documentation. We process 1000s of shipments through SE daily and it can be difficult for us to tackle these fixes on our own while maintaining our code base. We are trying to get off the old SE SDK that was published, so my apologies for the flood of open issues. If we can find the time to resolve them, we will help where we can.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants