Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove io.shiftleft.semanticcpg.language.operatorextension #985

Open
bbrehm opened this issue Oct 6, 2020 · 0 comments
Open

Remove io.shiftleft.semanticcpg.language.operatorextension #985

bbrehm opened this issue Oct 6, 2020 · 0 comments

Comments

@bbrehm
Copy link
Contributor

bbrehm commented Oct 6, 2020

The corresponding classes extend from Noderef.

This means that they create a second Noderef referencing the same underlying Node.

However, overflowdb cannot deal with that: The entire logic (e.g. https://github.com/ShiftLeftSecurity/overflowdb/blob/5bf234034dc7b58edf0983753adb253ce340578a/core/src/main/java/overflowdb/NodeRef.java#L91) synchronizes the storage on the Ref, not the node.

Afaiu this part of the API is not used in prod. So let's get rid of it, and afterwards add checks in overflowdb that guarantee the right invariant (every node can only have a unique reference to it).

cc @fabsx00 because you know best which parts of the API are important for whom, and @mpollmeier because you know overflowdb best.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant