Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: update ERC-165 #53

Open
mds1 opened this issue Aug 1, 2023 · 0 comments
Open

fix: update ERC-165 #53

mds1 opened this issue Aug 1, 2023 · 0 comments

Comments

@mds1
Copy link
Contributor

mds1 commented Aug 1, 2023

ERC-165 defines "the interface identifier as the XOR of all function selectors in the interface"

GovernorCountingFractional v1.1.0 added the fractionalVoteNonce public state variable (getter method) which therefore changes it's interface identifier. However, this is not currently reflected in it's supportsInterface method, which just uses the OZ Governor definition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mds1