-
Notifications
You must be signed in to change notification settings - Fork 147
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🐛 [BUG] - <title>Is this a bug in this Example? #1209
Comments
Hello @zhangxiaoshuotttt Thank you very much for reporting this issue! |
Thanks for your further check! On my side, I made two modifications on:
You can check the updated scripts here. I think flat case is ok with it. I continue with the topo example now. Thanks again! |
I made a pull request for modifying this error, at #1211 Thanks again for pointing this out! |
@mnagaso Hello, I apologize for the delayed response. Last week, I attempted to review your updated files and noticed some differences. Initially, I wanted to utilize your updated files to obtain correct results, but unfortunately, I was unsuccessful even when using the files updated yesterday.
Allow me to elaborate on the details. I first attempted to test your notebook but encountered an error. I then downloaded all the files within the Despite my efforts to troubleshoot, I could not pinpoint a specific error from the descriptions provided. I apologize for needing to reach out to you again. Additionally, please note that if we use Please accept my gratitude for your time and patience, |
Thank you very much for trying this update. After making the last commit, I noticed that there requires further modification on the creation of surf/abs files, which was writing out a wrong node ids. My latest pull request #1212 contains the corrected script for mesh conversion, thus you can run the example jupyter notebooks and will output: Thank you very much again for your signaling this issue, |
@mnagaso Hi, I am grateful for the time and effort you have dedicated to assisting me. Your recent updates have been helpful, and I have been trying to learn from them to understand better the root causes of the issues I have been experiencing. May I ask you another question? When I only changed the source position(30000, 18000), all boundaries were set as PML. Do you notice the waves I circled? I am unsure about their origin, and I would appreciate any advice you can offer when you can. Thank you once again for your unwavering patience and support. |
This is because the element size of the created mesh is a bit too large to avoid this kind of numerical artifacts. # test size in meter
lc_w = 0.25 * 1000
lc_g = 0.200 * 1000
if use_cpml:
# pml layer thickness
n_elm_pml = 6
# use lc_g instead of lc_w for pml layer because lc_g < lc_w
pml = lc_g * n_elm_pml then you will have a bit cleaner images. It is useful to visualize Thanks! |
That works well. I truly appreciate your help. This example helped me learn a lot. Thanks again for your time and patience. |
You're welcome! |
Description
@danielpeter @mnagaso Hello!
First of all, I want to express my gratitude for your example #1206 - it was really helpful. However, when I tried to move the source into the water (just like in an OBN geometry), I noticed some strange waves near the PML boundary. I used your original example, only adjusting the position of the source, without changing any other options. I observed some strange waves emanating from the boundary. Additionally, I am curious as to why all the waves are reflected from the sea bottom.
I then tried to only change the parameters
L,
H,
andH_w,
and the problem became even more apparent. Do you have any advice on why this happened? Thanks in advance!By the way, I have a question regarding the internal settings(I define the meshes by
interfaces.dat
). The wavefield of the simulation is working well; however, when I try to obtain the shotgather, there seems to be an issue. When I set the sea bottom as flat, the shotgather seemed to work well. What could be causing this problem?Affected SPECFEM2D version
latest development version
Your software and hardware environment
compiler and MPI: intel
Reproduction steps
Screenshots
![DESCRIPTION](LINK.png)
Logs
No response
OS
Linux
The text was updated successfully, but these errors were encountered: