Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Consolidate parsing of Expr::Name in TypeAliasName, MatchName, and Atom<Goal> #98

Open
zanieb opened this issue Jul 14, 2023 · 1 comment
Open

Consolidate parsing of Expr::Name in TypeAliasName, MatchName, and Atom<Goal> #98

zanieb opened this issue Jul 14, 2023 · 1 comment

Comments

@zanieb
Copy link
Contributor

zanieb commented Jul 14, 2023 •
edited
Loading

We have three parser descriptions for in the LALRPOP grammar for generating Expr::Name from an Identifier.

  • TypeAliasName
  • MatchName
  • Atom<Goal>

These could be consolidated into a single reused identifier for simplicity and clarity.

Originally posted by @MichaReiser in #97 (comment)
@zanieb zanieb mentioned this issue Jul 14, 2023
Merged
@zanieb
Copy link
Contributor Author

zanieb commented Jul 26, 2023

TypeAliasName may not be compatible with MatchName per #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@zanieb