Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

file may be corrupted #111

Open
gjaegy opened this issue Jul 10, 2024 · 5 comments
Open

file may be corrupted #111

gjaegy opened this issue Jul 10, 2024 · 5 comments
Labels

Comments

@gjaegy
Copy link

gjaegy commented Jul 10, 2024

Hi Milos,

I hope you are well.

I'm using MTuner again, but I'm facing some random issues, where the capture file gets sometimes corrupted (and sometimes not).

I've uploaded the capture file (it seems two files are always created).

http://www.imagine3d.fr/_temp/MTuner.rar

I'm using the latest 4.8 version of MTuner.

Any idea what's causing that ?

thanks a lot !

@milostosic
Copy link
Collaborator

Hello, I'm off to vacation today - let's revisit this in ~2 weeks.

@gjaegy
Copy link
Author

gjaegy commented Jul 11, 2024

Thanks for your prompt answer, enjoy your time off then !

@gjaegy
Copy link
Author

gjaegy commented Jul 11, 2024

After some furhter investigations, it seems the issue is likely due to a concurrency issue.

We compile our shaders using multiple threads. With the original code (multiple threads), the capture file is corrupted most of the time (5-10% of the times it's not), and I have some false positive memory leaks.

When compiling the shaders in a single thread, the corruption doesn't occur, as the false positives.

@milostosic
Copy link
Collaborator

Thanks! It's been a long time suspicion that there's a threading issue which would almost certainly be in rmem project if you'd like to chase this further while I'm away

@gjaegy
Copy link
Author

gjaegy commented Jul 11, 2024

I'm afraid I won't have enough time, I'll be on vacation starting from tomorrow and hence have to complete a few things before I leave :/

@milostosic milostosic added the bug label Nov 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants