You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Oct 30, 2022. It is now read-only.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Hello @aasitvora99 , thank you for your submission of this Issue.
I have tested the home and addEnvironment python pages in streamlit, didn't know this library nor have ever used it but seems a really cool and easy way to implement visual functionalities through python, still, the addMotor and addRocket were not implemented and the ability to save the specification given by the user also were not created, therefore I can't give you the points associated to a Hard task, still I liked a lot your code and the strategy for creating the Interface and hope that you can contribute to RocketPy in the future!
Hello @aasitvora99 , thank you for your submission of this Issue. I have tested the home and addEnvironment python pages in streamlit, didn't know this library nor have ever used it but seems a really cool and easy way to implement visual functionalities through python, still, the addMotor and addRocket were not implemented and the ability to save the specification given by the user also were not created, therefore I can't give you the points associated to a Hard task, still I liked a lot your code and the strategy for creating the Interface and hope that you can contribute to RocketPy in the future!
Thank you @luimot for a solid review.
This is indeed a not completed pull request, and some features were lacking at the final submission.
However, taking time to try solving such a hard pull request in a 48 hours hackathon was definetely a chellenge. I'd like to recognize @aasitvora99 's effort here, it was a good pull request at the end.
With that in mind, I am associating points as if it was a medium task.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
giovaniceotto
added
penalty
Pull request type
Please check the type of change your PR introduces:
Pull request checklist
Please check if your PR fulfills the following requirements, depending on the type of PR:
ReadMe, Docs and GitHub maintenance:
Code base maintenance (refactoring, formatting, renaming):
black rocketpy) has passed locally and any fixes were madepytest --runslow) have passed locallyCode base additions (for bug fixes / features):
black rocketpy) has passed locally and any fixes were madepytest --runslow) have passed locallyWhat is the current behavior?
Enter text here...
What is the new behavior?
Enter text here...
Does this introduce a breaking change?
Other information
Enter text here...