Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

colorscheme - colors too bright #8

Open
bragmore opened this issue Nov 10, 2019 · 5 comments
Open

colorscheme - colors too bright #8

bragmore opened this issue Nov 10, 2019 · 5 comments
Labels
good first issue Good for newcomers

Comments

@bragmore
Copy link

bragmore commented Nov 10, 2019

Hi,

I simply love this theme - it's my go-to theme for all editors.

You did an amazing job on this theme! Although I think the background is too bright compared to the iterm2 background colors. Can you look into it?

Also the colors of the syntax is not as bright as it should be. I know it changed over time which is probably why the colors differ. Otherwise - I love this theme so much!

Thanks alot and keep up the good work buddy.

Best,

J

@Rigellute
Copy link
Owner

Thanks @JonatanSiden!

So after some investigation, it looks like our vim version is using the correct background colour (#2D2B55) as the original VSCode theme.

Vim palette

image

VSCode

image

The terminal version of the theme uses the Background Dark (#1E1E3F) variation for the background - hence the disparity.

We could diverge from the original theme and use the darker variation for the vim background - I've just tried this but it throws off the balance with other colours.

@bragmore
Copy link
Author

Hi, ok I understand. Is it possible to solve anyway somehow? it would be amazing to get the colors that is used for the syntax in the actual theme to pop, maybe look for the exact colors in the iterm2 theme?

Best,

J

@Rigellute
Copy link
Owner

We could do it. As this would deviate from the original theme, I think we should create a side branch with the darker alternative theme. And then users can choose which version to use.

The master branch will stay as it is, and this side branch can be for the dark alternative.

@bragmore
Copy link
Author

We could do it. As this would deviate from the original theme, I think we should create a side branch with the darker alternative theme. And then users can choose which version to use.

The master branch will stay as it is, and this side branch can be for the dark alternative.

That would be amazing! and I would appreciate it alot as I live for this theme, like really!

Best,

J

@Rigellute Rigellute added the good first issue Good for newcomers label Nov 26, 2019
@bragmore
Copy link
Author

bragmore commented Dec 4, 2019 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants