Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove individual roterms from profile crates #83

Open
stain opened this issue Jun 25, 2024 · 0 comments
Open

Remove individual roterms from profile crates #83

stain opened this issue Jun 25, 2024 · 0 comments

Comments

@stain
Copy link
Contributor

stain commented Jun 25, 2024

From #73 (comment)

I think if the terms are defined now properly in the roterms namespace (incl. HTML!) we no longer need to define them individually in the profile crates, just refer to the DefinedTermSet alone. Will raise as new issue for 0.6, that's just housekeeping, no harm in the current way except duplication.

So suggestion is to remove each of the DefinedTerm to avoid this sublisting in https://github.com/ResearchObject/workflow-run-crate/blob/main/docs/profiles/0.6-DRAFT/process_run_crate/ro-crate-metadata.json#L329 and each DefinedTerm reference as that will essentially be re-declaring what is now deployed on https://w3id.org/ro/terms/workflow-run and we no longer need ad-hoc definitions in our Profile Crates.

Instead there will just be a DefinedTermSet reference only, as specified in https://www.researchobject.org/ro-crate/specification/1.2-DRAFT/profiles.html#extension-vocabularies

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant