Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Basedir for data files #55

Open
jjkoehorst opened this issue Jun 22, 2023 · 1 comment
Open

Basedir for data files #55

jjkoehorst opened this issue Jun 22, 2023 · 1 comment

Comments

@jjkoehorst
Copy link

Would it be ok to have a landing folder for the data files?
Now it is placed in the root of the crate but this creates quite some clutter.

There are only 2 lines I think that needs to be changed if it is ok that contain

dest = Path(parent.id if parent else "") / hash_

which could turn into

dest = Path(parent.id if parent else "data") / hash_

I can create a pull request but maybe it is better to have a discussion first?

@simleo
Copy link
Collaborator

simleo commented Jun 23, 2023

I think it's better to put this on hold for now. We still have to see how the proposed changes to data file name / subdir in cwltool will affect runcrate run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants