Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Boolean filtering support #195

Open
slemrmartin opened this issue May 28, 2020 · 2 comments
Open

Boolean filtering support #195

slemrmartin opened this issue May 28, 2020 · 2 comments
Assignees

Comments

@slemrmartin
Copy link
Contributor

Filter supports only string and int filtering.

Boolean would be handly for avalability checks to ask for less data if more endpoints available

https://github.com/RedHatInsights/insights-api-common-rails/blob/master/lib/insights/api/common/filter.rb

@syncrou
Copy link
Contributor

syncrou commented Jun 5, 2020

@mkanoor @bzwei do you have any thoughts on this?

@syncrou syncrou self-assigned this Jun 5, 2020
@mkanoor
Copy link
Contributor

mkanoor commented Jun 5, 2020

@syncrou @abellotti mentioned that there is already a pattern in the filter.rb which we can extend to support booleans. We have
https://github.com/RedHatInsights/sources-api/blob/1bc1d8da8aed4d188d5eb5cb0725a3d80038b041/public/doc/openapi-3-v3.0.json#L1705
Which uses a boolean field but it's not being filtered on.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants