Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate nx to latest v20, bump typescript-eslint to v7 #7511

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

JamesHenry
Copy link
Contributor

@JamesHenry JamesHenry commented Oct 29, 2024

Description:

I ran nx migrate latest to bring the repo up to date with the latest nx and @nx/* packages, including some minor configuration optimizations.

I bumped typescript-eslint packges to v7 as well. We can do the migration to ESLint v9 and typescript-eslint v8 in a separate PR.

This PR can go in once #7512 is merged which fixes all existing issues with the repo's CI that are unrelated to this.

Copy link

nx-cloud bot commented Oct 29, 2024

☁️ Nx Cloud Report

CI is running/has finished running commands for commit 8f2c447. As they complete they will appear below. Click to see the status, the terminal output, and the build insights.

📂 See all runs for this CI Pipeline Execution


🟥 Failed Commands
nx compile rxjs

Sent with 💌 from NxCloud.

@JamesHenry JamesHenry changed the title chore: migrate nx to latest v20, bump TS and typescript-eslint chore: migrate nx to latest v20, bump typescript-eslint to v7 Oct 29, 2024
@JamesHenry
Copy link
Contributor Author

JamesHenry commented Oct 29, 2024

Node 18 is fine, it looks like the latest Node 20 (20.18.0) which the Node 20 job is configured to use, has actually implemented FinalizationRegistry which was added to the tests 4 years ago (!) but has not actually been in use because of it not being present globally in Node until now.

This is obviously a very surprising discovery, but for now I spun out a dedicated fix PR here: #7512

UPDATE: That PR also fixes the long standing TS compilation issue on latest TS versions (again unrelated to Nx or its version)

@irajsava
Copy link

u

@irajsava
Copy link

Ok

@irajsava
Copy link

__

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants