You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Not all families in the RMG-db appear in the recommended.py file.
I'm not sure whether this is on purpose or not, but it is worthwhile to check.
For example, the H2_Loss family seems very reasonable and beneficial for models, yet it is never used by RMG unless explicitly asked for by the user in the input file.
I think it should be added to default and ch_pyrolysis. It is also a good idea to go over all of our families and see that they are included in recommended.py appropriately.
The text was updated successfully, but these errors were encountered:
Not all families in the RMG-db appear in the recommended.py file.
I'm not sure whether this is on purpose or not, but it is worthwhile to check.
For example, the
H2_Loss
family seems very reasonable and beneficial for models, yet it is never used by RMG unless explicitly asked for by the user in the input file.I think it should be added to
default
andch_pyrolysis
. It is also a good idea to go over all of our families and see that they are included in recommended.py appropriately.The text was updated successfully, but these errors were encountered: