Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The build script is totally hosed ... #116

Open
Jaykul opened this issue Apr 24, 2021 · 0 comments
Open

The build script is totally hosed ... #116

Jaykul opened this issue Apr 24, 2021 · 0 comments

Comments

@Jaykul
Copy link

Jaykul commented Apr 24, 2021

  1. First it doesn't [CmdletBinding()] ....
  2. Then, it tries to -ForceBootstrap on NuGet (without -Scope) which requires elevation
  3. Then, it tries to install some modules with -Force, meaning it installs them every time
  4. Then it installs some other modules without -Scope, meaning it has to be elevated
  5. Then it doesn't explicitly import Pester 4, meaning all the tests fail
  6. But worse, the built module won't work, because it's missing the initialization code which only exists in PSSlack.psm1

Of course, it turns out you're not using the build anyway, you're just shipping the source!

I would suggest using Install-RequiredModule, or maybe PSDepends 😉, and stick that initialization code into a private folder somewhere...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant