Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RainbowSixSiegeBridge] Markdown videos added as images #3614

Closed
Rakambda opened this issue Aug 14, 2023 · 2 comments · Fixed by #3619
Closed

[RainbowSixSiegeBridge] Markdown videos added as images #3614

Rakambda opened this issue Aug 14, 2023 · 2 comments · Fixed by #3619
Labels
Bug-Report Confirmed bug report

Comments

@Rakambda
Copy link

Describe the bug
Videos are put inside img elements and is therefore unplayable/doesn't render.

To Reproduce
Steps to reproduce the behavior:

  1. Load feed from the bridge
  2. Recent post Y8S3 DESIGNER’S NOTES has videos

Expected behavior
Videos to be put inside a video tag.

Screenshots
DOM from the R6 website:
image

Bridge response:
image

Additional context
I don't know much how the bridge works, but quickly looking at the request made by it, it seems the response is in markdown, and therefore doesn't care if it's a picture or video.
image

Seems like a lib is used to do the translation so I don't know how fesible it is to maybe change img into video based on the extension?

This may be related and give ideas: erusev/parsedown#849

@Rakambda Rakambda added the Bug-Report Confirmed bug report label Aug 14, 2023
@dvikan
Copy link
Contributor

dvikan commented Aug 14, 2023

@corenting

@corenting
Copy link
Contributor

I'm taking a look

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug-Report Confirmed bug report
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants