Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing serif parts of some letters #216

Open
ciro-mota opened this issue Nov 3, 2024 · 9 comments
Open

Missing serif parts of some letters #216

ciro-mota opened this issue Nov 3, 2024 · 9 comments

Comments

@ciro-mota
Copy link

I have been using Wavefox for many months, but when I migrated to a new Fedora installation and installed the changes, I noticed that parts of the letter "g" were not visible. I use the forced compact mode via prefs, but the problem also occurs when using the normal mode.

2024-11-03_17-08

As a comparison, I opened another instance of Firefox in AppImage also with compact mode and noticed that the problem does not occur.

2024-11-03_17-18

@QNetITQ
Copy link
Owner

QNetITQ commented Nov 3, 2024

I expected something like that. On Linux, fonts are usually larger than on other systems. They may not fit into the block. I'll fix it for the next release.

@QNetITQ
Copy link
Owner

QNetITQ commented Nov 4, 2024

I made some adjustments. Now the fonts should not go beyond their block.

@ciro-mota
Copy link
Author

Thank you. 🤝

@ciro-mota
Copy link
Author

The font size has been reduced in this latest release, was this the expected behavior?
If so, the reported issue has been resolved.

2024-11-16_14-34

@ciro-mota
Copy link
Author

Sorry for adding this extra comment after closing, but I would like to share a discovery. Since I found that with this modification the tab titles were in very small fonts, I decided to do a test by disabling your theme and adding some of my own functions to userChrome.css.

I got a similar result to yours with just these lines below, without changing the font aspect, just the size of the tabs starting from the default aspect.

2024-11-17_15-51

Wouldn't it be possible to add something similar to this in your theme?

.tabbrowser-tab[selected] {
  max-height: 32px !important;
  min-height: 32px !important;  
}   
tab:not([selected="true"]) {
  max-height: 32px !important;
  min-height: 32px !important;  
}

@ciro-mota ciro-mota reopened this Nov 17, 2024
@QNetITQ
Copy link
Owner

QNetITQ commented Nov 17, 2024

Try this code. It doesn't make the fonts smaller, but it changes the distribution of space between blocks of text.

/* -------------------- Tab Text -------------------- */

.tab-label-container
{
    height: var(--tab-min-height) !important;
    mask-image: none !important;
}

.tab-label
{
    width: 100% !important;
    height: 20px !important;
    line-height: 20px !important;
    overflow: hidden !important;
    text-overflow: ellipsis !important;
    margin-block: 0px !important;
}

#tabbrowser-tabs[secondarytext-unsupported] .tab-label
{
    height: var(--tab-min-height) !important;
    line-height: var(--tab-min-height) !important;
}

.tab-secondary-label
{
    width: 100% !important;
    height: 12px !important;
    line-height: 12px !important;
    overflow: hidden !important;
    margin-block: auto 0px !important;
    order: -1 !important;
}

.tab-secondary-label > *
{
    width: 100% !important;
    height: 12px !important;
    line-height: 12px !important;
    overflow: hidden !important;
    text-overflow: ellipsis !important;
}

@ciro-mota
Copy link
Author

It worked perfectly, thanks! But that's not what I was referring to, if I made it seem that way I apologize. What I meant is, why instead of changing the font aspect, not just increase the tab height size by 2 or 3px so that the default font size fits in the space?

@QNetITQ
Copy link
Owner

QNetITQ commented Nov 17, 2024

The tabs will take up more vertical space if I increase their height. This is not very good. But this is not the biggest problem. The style is very dependent on the anchor height of the tabs. Any change to this height breaks a lot of things. I have been trying to untie the style from the anchor height for a long time, but so far with mixed success.

@ciro-mota
Copy link
Author

I understand. I appreciate your attention to my question and I am available if you need to perform any tests derived from this issue in the future. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants