-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add the capability to prescribe existing segmentations to individual findings #1
Comments
@naucoin if you are not done with the Reporting orientation precision issue (and its relatives!) you were working on, ignore this, let me know when you are done. |
I'm getting the next pull request together today for the precision issue, will take a look at the new feature for this issue this afternoon. |
As I understand it, the request is to add segmentations loaded from disk or otherwise created and use it as a finding. Also: it sounds like this is very much related to the work that Andras and Csaba will be doing on the new segmentations for Slicer, so it would make more sense in the long term to convert this module to use their algorithms rather than to work with the current label volumes. |
If I've misunderstood the problem or the code, let's meet in person to go over it for sure. |
Thanks! Can you look into the vtkMRMLLongitudinalPETCTFindingNode? Somewhere down there it must keep a reference to the label node, so we would just need to initialize it correctly. There is no custom internal representation for the segmentation, so no algorithmic conversion is needed. |
I dug more into this and ran the screencast tutorial so I could understand the workflow a bit better (the code has some copy/paste errors or at least ambiguities in the node documentation). |
Thanks! Let's talk before you do anything else on this issue. I want to take a look myself and then discuss with you. |
Sounds good, I'm not feeling confident yet that I have the whole workflow sussed out. |
Let's explore the idea to allow user to select a label volume that already exists in the scene in this popup dialog raised on "Create finding". The label volume associated with the newly created finding should be populated by resampling the user-selected label volume to the label volume matching the image geometry. If there are multiple label values in the user-selected label volume, threshold all to the color selected by the user. It looks like there is a label volume associated with the report node created by LongitudinalPETCT DICOM plugin. For the reference, the architecture of the extension should be described to some degree in Paul's thesis: http://www.spl.harvard.edu/publications/item/view/2444 When done, add a comment to the info button about this capability: "You can select existing label volume to initialize finding segmentation" |
Removed trailing and empty line spaces to conform to Slicer coding style. Issue QIICR#1
Fixes failure to enter the module. Issue QIICR#1
Yes, I think this is fine On Fri, Jun 5, 2015 at 1:08 PM, Nicole Aucoin [email protected]
|
Added an attribute on the finding node to pass along the id of a prior segemented label map volume to use when adding a finding. The module workflow is split up across multiple small functions so the passing of the prior volume information isn't as clean as it could be with a redesign. Issue QIICR#1
Removed trailing and empty line spaces to conform to Slicer coding style. Issue QIICR#1
Fixes failure to enter the module. Issue QIICR#1
Added an attribute on the finding node to pass along the id of a prior segemented label map volume to use when adding a finding. The module workflow is split up across multiple small functions so the passing of the prior volume information isn't as clean as it could be with a redesign. Issue QIICR#1
Please check out my branch and see if it does what you expect. |
Nicole, when do you estimate this issue will be resolved? |
Debugging it today (took a lot of refactoring to move the functionality), hopefully by the end of tomorrow a new version of the topic branch will be ready for feedback. |
I've got a missing connection (the new finding accept button isn't working correctly, though it works if you press cancel instead), but other than that it seems to be sucessfully refactored. I'll take another look at it on Monday morning and share the branch for review. |
Move the selection of a prior segmented volume for initialising a finding from the finding settings dialog to the module. To do: don't over write the prior volume when thresholding it. Issue QIICR#1
The accept button is working now, and I'm trying to ensure that I don't over write the prior volume when thresholding it (makes it hard to init a second finding from the first!). Current branch does the over write: |
Fixed a method name typo found during testing. Creates a temporary volume to hold the thresholded prior to avoid over writing the original volume. MRML scene event oddities were causing the temporary and removed nodes from still showing up in the prior segmentation drop down widget, setting nodes hidden and unsetting then resetting the MRML scene on the widget seemed to fix that problem. Issue QIICR#1
I think this is working now, I tested it with the PETCTFusion data set and went through each logic path. The prior segmentation drop down widget is behaving unpredicatably though so I had to hide some nodes and unset/reset the MRML scene on it. |
See discussion at http://slicer-users.65878.n3.nabble.com/prescribing-existing-segmentation-and-accessing-SUV-by-parsing-DICOM-Metadata-td4028511.html
The text was updated successfully, but these errors were encountered: