-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to install Whisky in subdirectory #75
Comments
That's a really interesting edgecase that I'd never even considered. Do you have time to throw together a quick and dirty proof of concept pr? If not, that's ok |
Hey @ProjektGopher! First of all, thank you for this repo! Already satisfied by whiskey on 1 project despite I don't drink alcohol 😄 I just found the same problem as @pindab0ter on another project. I'd like to collaborate to add the feature asap, so feel free to text me on Telegram: @Alexxosipov |
That's awesome, @Alexxosipov! I'm glad you're enjoying it too! I was hoping to get @pindab0ter's PR merged last week, but my whole family got pretty sick, and then this week was Laracon. I'm in the airport right now, but when I'm settled again I'm eager to get this finished up. If you decide to look over the linked PR and happen to notice anything let me know! I'll probably finally get this feature merged on Monday or Tuesday. |
I've got this partially working with the PR that came in, but I'm stalled on it. So we have our mono-repo, in which our git repo is initialized. We then have projects in subdirectories. These directories should each be able to have whisky as a dep, but only optionally. These hooks then should be able to be run from within those subdirectories, but nowhere else. I've moved the PR to |
We have a project structure where the directory that should contain the Whisky dependency is a subfolder, not the root.
When using
vendor/bin/whisky install
I getGit has not been initialized in this project, aborting...
. However, runninggit status
works fine.Maybe this can be solved by using something like
git rev-parse --is-inside-work-tree
andgit rev-parse --absolute-git-dir
to make Whisky directory-agnostic?The text was updated successfully, but these errors were encountered: