Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwinMM/Initialize the SwinMM project #296

Merged
merged 9 commits into from
Aug 11, 2023
Merged

Conversation

Zi-hao-Wei
Copy link
Contributor

Hi, I add the SwinMM project into this repository.

@Zi-hao-Wei Zi-hao-Wei changed the title feat(SwinMM):Add the SwinMM project SwinMM/Initialize the SwinMM project Aug 9, 2023
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the PR, it looks great, please help fix those two minor issues

@Zi-hao-Wei
Copy link
Contributor Author

Hi, I have fix the problems. Could you please check it again? Thanks.

@tangy5
Copy link
Contributor

tangy5 commented Aug 11, 2023

This is great, thank you.

@tangy5
Copy link
Contributor

tangy5 commented Aug 11, 2023

This PR looks good to me:
HI @Zi-hao-Wei can you double check:

  1. Whether there are duplicated or unused lines of code in your scripts.
  2. Whethere there are additional license.
  3. I saw the WORD_finetuned.pt is actually the BTCV finetined checkpoint download link, is that correct?
  4. Can you add MONAI paper reference to the README.md?
@article{cardoso2022monai,
  title={Monai: An open-source framework for deep learning in healthcare},
  author={Cardoso, M Jorge and Li, Wenqi and Brown, Richard and Ma, Nic and Kerfoot, Eric and Wang, Yiheng and Murrey, Benjamin and Myronenko, Andriy and Zhao, Can and Yang, Dong and others},
  journal={arXiv preprint arXiv:2211.02701},
  year={2022}
}

Thanks

@tangy5 tangy5 self-requested a review August 11, 2023 02:48
@wyli
Copy link
Contributor

wyli commented Aug 11, 2023

/black

@Zi-hao-Wei
Copy link
Contributor Author

Thanks for your reply. To address your concerns:

  1. No duplicated or unused lines in the scripts.
  2. No additional license.
  3. This is a naming error and I have fixed the sharing link. Thank you for pointing out.
  4. I have added it to the Citation part in README.md

wyli and others added 3 commits August 11, 2023 08:59
@wyli wyli merged commit 0cd69f2 into Project-MONAI:main Aug 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants