Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Making max_workers a configurable parameter in the workload config JSON #23

Closed
Nalin28 opened this issue Oct 13, 2023 · 1 comment
Closed
Assignees
Labels
enhancement New feature or request

Comments

@Nalin28
Copy link

Nalin28 commented Oct 13, 2023

I used faas-profiler to send traffic to Knative (endpoint: generic) and it only sends in 100 async request invocations even though my workload config JSON has an ideal peak average concurrency of more than 100.

Steps to reproduce:

Use the workload_configs_generic_endpoint.json under faas-profiler and specify your host and URL (I used it with interarrivals_list with average peak concurrency > 100).
run $ ./WorkloadInvoker -c workload_configs_generic_endpoint.json

Fix

Pass the field in the JSON as max_worker and propagate it through the WorkloadInvoker instead of hardcoding it.

@engshahrad engshahrad self-assigned this Oct 13, 2023
@engshahrad engshahrad added the enhancement New feature or request label Oct 13, 2023
@engshahrad
Copy link
Collaborator

#32 also resolves this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants