Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

News icon always shows exclamation point on startup #450

Open
kjack9 opened this issue Oct 28, 2024 · 4 comments
Open

News icon always shows exclamation point on startup #450

kjack9 opened this issue Oct 28, 2024 · 4 comments
Assignees
Labels
🪲 bug Something isn't working 💻 client There are things to do on the client

Comments

@kjack9
Copy link

kjack9 commented Oct 28, 2024

Describe the bug
The News icon in the bottom left bar always shows the "new news" exclamation point on startup, even if there is nothing new. The exclamation point goes away after clicking the icon, but re-appears the next time the app is restarted.

To Reproduce
Steps to reproduce the behavior:

  1. Close app
  2. Open app
  3. Observe exclamation point
  4. Click news icon and observe exclamation point disappearing
  5. Close app
  6. Open app
  7. Observe exclamation point

Expected behavior
Exclamation point should only show if there is new news

Screenshots
image

Desktop (please complete the following information):

  • OS: Win10

Additional context
N/A

@kjack9 kjack9 added 💻 client There are things to do on the client 🪲 bug Something isn't working labels Oct 28, 2024
@Alfagun74
Copy link
Contributor

Are you absolutely sure nothing changed?

The exclamation mark should only be visible if either GameVault News or Server News have changed.

@Yelo420 how do we the save news state?

@Yelo420
Copy link
Contributor

Yelo420 commented Oct 29, 2024

That’s strange. The news state is saved by creating a hash of the 'GV News' and 'Server News' and comparing it with the previous one.
@kjack9, if you’re sure that nothing has really changed, could you take a look at the server message and let me know if there are any special characters, or if it’s empty? I’m looking for any specific cases that could be causing this.

@kjack9
Copy link
Author

kjack9 commented Oct 29, 2024

That’s strange. The news state is saved by creating a hash of the 'GV News' and 'Server News' and comparing it with the previous one. @kjack9, if you’re sure that nothing has really changed, could you take a look at the server message and let me know if there are any special characters, or if it’s empty? I’m looking for any specific cases that could be causing this.

100% sure since I don't have a server message set. The "GameVault News" tab shows the initial message -- "Welcome to the new GameVault news section!". My "Server News" is blank as I haven't set it up with anything.

Also note that there is sometimes a delay before the exclamation point shows up again -- a few hours ago I closed and re-opened, and it wasn't there. Checked again just now, and it's back.

@Yelo420
Copy link
Contributor

Yelo420 commented Oct 30, 2024

Hi @kjack9 we are not able to reproduce this problem. Would it be possible to provide us a guest account, so we can look deeper into this? Write to [email protected]. Else i can send you a modified GameVault version, that shows us exactly the changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🪲 bug Something isn't working 💻 client There are things to do on the client
Projects
Status: 📃 New Issues
Development

No branches or pull requests

3 participants