Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add version information to the ServerAd structure #1725

Open
2 tasks done
turetske opened this issue Nov 11, 2024 · 0 comments · May be fixed by #1753
Open
2 tasks done

Add version information to the ServerAd structure #1725

turetske opened this issue Nov 11, 2024 · 0 comments · May be fixed by #1753
Assignees
Labels
enhancement New feature or request
Milestone

Comments

@turetske
Copy link
Collaborator

turetske commented Nov 11, 2024

Pelican Service:

  • Origin
  • Cache

As part of getting origin versions from the prometheus metrics at the director, the director needs to have some idea of origin versions.

Generally, the way the Director gets its information from the Origin is via the Origin advertising information to the director. So additional information needs to be added to the ServerAd structure. This will also allow us to advertise version information from Cache's as well, since this would be general server information

Short version: Add a field in the ServerAd struct (in server_structs/director.go) that reports a version in the form of v<x>.<y>.<z> (eg. v7.11.10) and update the Origin and Cache code to populate this information on startup. Look in launchers/ to see where the startup code is.

@turetske turetske added the enhancement New feature or request label Nov 11, 2024
@turetske turetske added this to the v7.12.0 milestone Nov 11, 2024
@patrickbrophy patrickbrophy linked a pull request Nov 18, 2024 that will close this issue
@patrickbrophy patrickbrophy linked a pull request Nov 18, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants