Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OpenPojo suddenly started silently not getting coverage #124

Open
davidmichaelkarr opened this issue Sep 12, 2018 · 1 comment
Open

OpenPojo suddenly started silently not getting coverage #124

davidmichaelkarr opened this issue Sep 12, 2018 · 1 comment

Comments

@davidmichaelkarr
Copy link

We've been using OpenPojo in a couple of related projects for a while, and it's been working fine, giving us test coverage in our getters and setters. Somehow, in the last few days, we discovered that our test coverage had dropped for certain builds using this. I narrowed it down to the classes being tested by OpenPojo. We haven't changed how we use it. I verified that running the tests locally successfully get full coverage. I even saw variations in that "master" builds were not getting coverage, but pull request builds (without any actual changes) were getting coverage.

Quite a while ago, I had written my own version of this kind of tool, which was working fine, and also verified my brand of "fluent setters". I started using OpenPojo because I felt it was better to use a well-known library for this. I just now made a small modification to the tests that are using OpenPojo, to make it use my custom tool for a single class, and when I looked at the coverage results in SonarQube, all the other pojos still had low coverage, but the single class I tested with my own tool had full coverage.

I still like the idea of using OpenPojo, so is there some logging level I can turn on that will give me some information about what it's doing? I didn't see anything in the readme in the repo.

@oshoukry
Copy link
Member

oshoukry commented Jan 4, 2019

David,
Do you know the tests that stopped working on the build machine?
Any chance someone is passing some parameter to your build that is causing OpenPojo to not run?
Are all classes tested by OpenPojo not getting covered, or some special types (i.e. Abstract classes, etc.).

Without more information, it is really hard to guess as to what would cause OpenPojo to stop testing, but if you have dependencies that started to pull in older ASM library this may be a cause, OpenPojo latest 0.8.11 now supports ASM version 5.0 - 7.0, take a look at your dependency graph if you are using Maven and see what libraries are getting pulled in.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants