Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion: Move imports to local scope #494

Open
zain-sohail opened this issue Aug 24, 2024 · 1 comment
Open

Suggestion: Move imports to local scope #494

zain-sohail opened this issue Aug 24, 2024 · 1 comment

Comments

@zain-sohail
Copy link
Member

Due to how the current interface works, all possible dependencies are imported when importing SedProcessor from sed.

I propose we remove the linter for module level imports and import them in scope when necessary. This will reduce first time importing time from ~30 s to something more managable.

@rettigl
Copy link
Member

rettigl commented Oct 22, 2024

For me, it takes typically 10s max to load. As anyways all calibrators are loaded with the processor, I don't see that we would gain much.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants