-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RR2 and RD2 need updating following revision of QC flag definitions during ADMT-21 #21
Comments
Should note (c) - which contains further information on flags '5' and '8', also added as part of the December 2020 updates to Reference table 2 in Argo User Manual - be captured in the description of these two concepts as well? |
I'm not sure that's necessary as its usage rather than a definition. There are many other instances of additional information associated with reference tables were we could include it, but it is liable to be more than trouble than it is worth in the context of maintenance - especially considering there will be usage information in various different documents, particularly around QC. It does raise an interesting question though as to whether we ought to include some additional information in the collection descriptions to mention the Argo documentation. I'm not convinced this is necessary, but might be worth thinking about. |
@gwemon and @matdon17, table 2 at page 72 of the Argo User Manual (https://archimer.ifremer.fr/doc/00187/29825/80869.pdf) includes the following (code | meaning | comment): ‘ ‘ | FillValue | Empty space in NetCDF file Shall I go ahead and create an empty CODVAL/CODALT (i.e. Identifier and Alternative Label) for this term? I noticed that (non-Argo) tables C05 and C15 on the NVS each have a concept with empty CODVAL/CODALT. |
I do not know of any reasons why we wouldn't, although that's not to say there isn't. Are C05 and C15 externally exposed? I can't see them either through the search or VocPrez interface. |
@matdon17 @vpaba there isn't any precedent in the NVS. C15 and C05 are internal BODC vocabs not published on the NVS. I presume that it would not be possible to change the space value ' ' to something else? Or could this record be omitted from the NVS collection? |
Thinking about it a bit more - this is really just the entry for the NetCDF _FillValue variable attribute. I actually don't think it should appear in the reference table (even in the manual) at all. |
This term is new to the table, i.e. it is part of the most recent edits/additions to the manual. |
I'm not even sure URLs can have spaces, so I doubt the NVS can support it, and even if it can, it is part of the NetCDF standard and seems redundant. We have other reference tables where there is an acceptable _FillValue One for the next AVTT? |
Thank you both. I will take this to the next AVTT meeting. |
The ' ' QC is not really a QC. It concerns, at least, multiprofiles files ({wmo}_prof.nc): As mentioned by Matt, the space " " is indicated as the _FillValue attribute, so should be quite clear from a machine-2-machine perspective. Example: That said, I don't know if there are other occasions where we can have "empty space" for QC. Maybe in synthetic single profiles as well. I sometimes also encouter(ed) it in old single core profile files, but in this case, the profile file should be corrected (and it will not pass the latest File Checker if it had to anyway). I would partly agree with what Matt said on its comment from 2021/02/09 : it's part of the netCDF formalism, so I would not add it to the NVS. However, I would not remove it from the user manual but, preferably, I would add a little bit more explanation to detail when this case can occur. |
@delphinedobler , can you propose the "little bit more explanation to detail when this case can occur", I will add it to the user manual. Then we can close this ticket. |
I suggest adding it in §3.2.1 after the last line of the table, with an asterix:
I sugesst letting the 'e.g.' (example given), because I am not sure I have listed everything. |
At ADMT-21 the descriptions of real-time and delayed-mode flags was updated to be more comprehensive. These changes will need updating in vocabs RR2 and RD2.
Primary contact for these changes is Annie Wong.
The text was updated successfully, but these errors were encountered: