Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Folder Name Length causing crash #38

Closed
KayJay95 opened this issue Jun 22, 2024 · 4 comments · Fixed by #39
Closed

[BUG] Folder Name Length causing crash #38

KayJay95 opened this issue Jun 22, 2024 · 4 comments · Fixed by #39
Assignees
Labels
bug Something isn't working enhancement New feature or request

Comments

@KayJay95
Copy link

The Bug
If you run the Downloader with tags longer than 256 char it breaks as the output folder name cant be longer then that.

Error
[WinError 123] The filename, directory name, or volume label syntax is incorrect: 'media/22-06-2024_12-52-58_-vore_-death_-flash_-fart_-nipple_vore_-breast_expansion_-vore_pov_-unbirthing_-pooping_-body_size_growth_-urine_-soiling_-muscular_-big_breasts_-big_penis_-thick_thighs_de4dm1lk_fleurfurr_lettuce_artist_kind_lurker_ssevisx_81yffulfmm_noxxlss_ruffruffles_lintwave_4hazelstreet_uricomics_dudles_codyblue-731_100racs_replicant_skrunkle_lemonbird_rilesthecat_entom_kyufuru_lyonley_slashkill_domibun_lilmoonie'

To Reproduce

  1. Run the Downloader
  2. Select e621
  3. Type in any tags as long as they are, in total, longer than 256 characters
  4. See error

Expected behavior
Downloader should run normally (maybe allow users to name output folders / change them, as planned in #31)

Screenshot
image

Desktop:

  • OS: Windows
  • Version 11

Used Parameters and Settings:

  • Site: e621
  • Tool Version: v.1.6.3
  • Tags/Link (EXAMPLE): -vore -death -flash -fart -nipple_vore -breast_expansion -vore_pov -unbirthing -pooping -body_size_growth -urine -soiling -muscular -big_breasts -big_penis -thick_thighs ~de4dm1lk ~fleurfurr ~lettuce_(artist) ~kind_lurker ~ssevisx ~81yffulfmm ~noxxlss ~ruffruffles ~lintwave ~4hazelstreet ~uricomics ~dudles ~codyblue-731 ~100racs ~replicant_skrunkle ~lemonbird ~rilesthecat ~entom ~kyufuru ~lyonley ~slashkill ~domibun ~lilmoonie

runtime.log
runtime.log

@KayJay95 KayJay95 added bug Something isn't working enhancement New feature or request labels Jun 22, 2024
@Official-Husko
Copy link
Owner

Official-Husko commented Jun 22, 2024

god damnit, i knew this would come around to bite me in the ass. I will push a quick fix to address the issue.

Thanks for the report!

@Official-Husko
Copy link
Owner

Is it possible that the tags you provided have no results? While testing to see if the issue was resolved i saw that there are no results with these tags.

Official-Husko added a commit that referenced this issue Jun 22, 2024
fix: [BUG] Folder Name Length causing crash #38
fix: issue with to many tags on e6 sites
feat: proper folder management for e6 sites
feat: build windows exe on actions now for full transparency on the build process
@Official-Husko
Copy link
Owner

Official-Husko commented Jun 22, 2024

@KayJay95 do me a favor and try this build. If it works i can fully release it.
nn-downloader-windows.zip

@KayJay95
Copy link
Author

@Official-Husko Sorry it took me this long to respond, yes the version works perfectly, thank you :D 👍
image

Official-Husko added a commit that referenced this issue Jun 25, 2024
feat: building process now using github actions for full transparency
fix: #38
bump: idna to 3.7
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants