Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

avoid unspecific properties #297

Closed
VladimirAlexiev opened this issue Jul 16, 2021 · 5 comments
Closed

avoid unspecific properties #297

VladimirAlexiev opened this issue Jul 16, 2021 · 5 comments
Labels
module: ePO core ePO core type: bug something implemented incorrectly in a release
Milestone

Comments

@VladimirAlexiev
Copy link

The worst offender is epo:has (ePO_restrictions.ttl release 2.0.1):

epo:has  a           owl:FunctionalProperty ;
        rdfs:domain  [ a            owl:Class ;
                       owl:unionOf  ( epo:PlannedProcurementPart epo:Address epo:AwardDecision epo:Buyer epo:ContactPoint epo:Role epo:Procedure epo:EvaluationBoard epo:Lot )
                     ] ;
        rdfs:range   [ a            owl:Class ;
                       owl:unionOf  ( epo:AccessTerm epo:LocationCoordinate epo:Winner epo:BuyerProfile epo:Channel epo:ContactPoint epo:ContractTerm epo:DirectAwardTerm epo:ExclusionGround epo:Purpose epo:OpeningTerm epo:ProcedureTerm epo:Subcontract )
                     ] .

Not surprisingly, there is no definition of this prop.
You could add definition "A quality, part or characteristic of this resource" but it's quite unspecific

OP-TED/model2owl#91 complains about being unable to tell which domain class pairs with which range class.

But I looked in the UML documentation and I know one of the pairs is:
epo:EvaluationBoard epo:has epo:ExclusionGround.

But I still can't figure out:

  • how can a Board have an ExclusionGround? Aren't ExclusionGrounds applied on tenders and lots?
  • is it true that there can be only one ExclusionGround per EvaluationBoard (stated by owl:FunctionalProperty)? Aren't ExclusionGrounds various and sundry, and several of them can apply to the same case?

If there was a specific prop between epo:EvaluationBoard and epo:ExclusionGround, these questions could be answered by the ontology.

BTW, Is it true that epo:has is a owl:FunctionalProperty?

@giorgialodi
Copy link

Please see also comments in issue #281, where this specific property is mentioned :) In the current revisions, not yet published, this property will be changed.

@VladimirAlexiev
Copy link
Author

@giorgialodi Is it true that epo:has is a owl:FunctionalProperty?
It seems to me that at least the use of epo:has for ExclusionGround should be multi-valued.

@giorgialodi
Copy link

@VladimirAlexiev it seems so looking at the OWL file of the version 2.0.1 but I do not think it is correct. Here there are two points to highlight IMHO: 1) "has" is no longer available in the new version we are working on; we decided to revise all those properties that are applied to many domains and ranges and that can cause semantic inconsistencies and also, let me say, not clear semantics; 2) the definition of functional properties, (a)symmetric ones and also of the disjointedness axioms are to be revised: after some checks in the working group we noticed that there are some of these axioms that are not correct and this might be (we are not sure and we need to further investigate it) derived from some conventions adopted in the automatic translation from UML to OWL. The point is that I personally notice that automatic translation is cool from one side but adjustments are required in any case since UML is not that expressive as it is OWL and some things are not subject to a general rule: it depends on what we model. This consideration, from my personal point of view, might be applied to the functional axiom for "has" in the specific case you mention.

@guascce
Copy link

guascce commented Jul 22, 2021

As Giorgia rightly mentions we took care of revising all the predicates that were creating ambiguity.
We still need to refactor the code that produces the OWL from UML an d that controls the definition of specific axioms like FunctionalProperty. Cardinalities can help us define whether it would be Functionalproperty or not. This will be dealt in the next release.

@andreea-pasare andreea-pasare added type: bug something implemented incorrectly in a release module: ePO core ePO core labels Oct 12, 2022
@andreea-pasare
Copy link
Collaborator

This has been fixed. In the latest release, ePO 3.0.1, all properties are well scoped.

@andreea-pasare andreea-pasare added this to the 2022 Q4 milestone Nov 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
module: ePO core ePO core type: bug something implemented incorrectly in a release
Projects
None yet
Development

No branches or pull requests

5 participants