Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should MeshMagick be integrated into the OGRE repo? #3092

Open
sercero opened this issue Apr 28, 2024 · 7 comments
Open

Should MeshMagick be integrated into the OGRE repo? #3092

sercero opened this issue Apr 28, 2024 · 7 comments

Comments

@sercero
Copy link
Contributor

sercero commented Apr 28, 2024

I was wondering why MeshMagick sits apart from the rest of the OGRE tools.

@sercero sercero changed the title Should MeshMagick be integrated into OGRE? Should MeshMagick be integrated into the OGRE repo? Apr 28, 2024
@paroj
Copy link
Member

paroj commented Apr 28, 2024

it was started outside of Ogre, thats why it never was part of the Ogre tools. However, since I switched Ogre to the monotree approach, it could be merged.

That being said, there doesn't seem to be a great deal of interest or usage of the tool, and it would need to be updated to align with Ogre's current build, test, and documentation frameworks.

@sercero
Copy link
Contributor Author

sercero commented Apr 28, 2024

I think it would be useful to have amongst the other tools that come with OGRE, perhaps people are not aware of the tool because of that.

Anyway I wanted to know if you were open to integrating it....

@paroj
Copy link
Member

paroj commented May 3, 2024

the problem with integrating meshmagick is that it is also a library as shown by the doxygen file in the repo. So we would need to split it into a component and a tool which complicates things.

Also one should clean up the code before merging:

  • replace tootle
  • remove the ogre-next ifdefs

for now I have added it to the tools page on the website:
https://www.ogre3d.org/download/tools

@sercero
Copy link
Contributor Author

sercero commented May 4, 2024

the problem with integrating meshmagick is that it is also a library as shown by the doxygen file in the repo. So we would need to split it into a component and a tool which complicates things.

Also one should clean up the code before merging:

  • replace tootle
  • remove the ogre-next ifdefs

for now I have added it to the tools page on the website: https://www.ogre3d.org/download/tools

Is tootle obsolete?

If there are ogre-next ifdefs then perhaps it is an argument against integrating it into this repo...

@paroj
Copy link
Member

paroj commented May 4, 2024

Is tootle obsolete?

yes, see OGRECave/meshmagick#7

If there are ogre-next ifdefs then perhaps it is an argument against integrating it into this repo...

it is actually a separate branch. forgot the details.

looking at the commits, it seems that tootle is the most used feature. For that we could just improve -optvtxcache in MeshUpgrader by using meshoptimizer directly.

@sercero
Copy link
Contributor Author

sercero commented May 4, 2024

Is tootle obsolete?

yes, see OGRECave/meshmagick#7

OK, tootle is discontinued by AMD but is it not useful anymore?

If there are ogre-next ifdefs then perhaps it is an argument against integrating it into this repo...

it is actually a separate branch. forgot the details.

looking at the commits, it seems that tootle is the most used feature. For that we could just improve -optvtxcache in MeshUpgrader by using meshoptimizer directly.

Is it a proper replacement for tootle? I'm asking from ignorance.

Thanks

@paroj
Copy link
Member

paroj commented May 4, 2024

Is it a proper replacement for tootle? I'm asking from ignorance.

I have no idea how what the ranking of current -optvtxcache vs tootle vs meshoptimizer is. Someone would need to benchmark I guess..

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants