Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to configure deb build dependencies by repository #42

Open
SirTakobi opened this issue Jan 24, 2023 · 1 comment
Open

Allow to configure deb build dependencies by repository #42

SirTakobi opened this issue Jan 24, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@SirTakobi
Copy link

SirTakobi commented Jan 24, 2023

Is your feature request related to a problem?
Yes, some modules require pip packages that require deb packages in order to be installed.
An example is in https://github.com/OCA/server-tools/blob/10.0/base_external_dbsource_odbc: it depends on pyodbc (https://pypi.org/project/pyodbc) that needs unixodbc-dev, as explained in its documentation https://github.com/mkleehammer/pyodbc/wiki/Install#installing-on-linux

Describe the solution you'd like
Configure apt packages on a per-repo basis that will be installed before installing Python libraries.

Describe alternatives you've considered
A step can be added in the github actions that installs the apt packages before installing pip packages, but as far I as understand, that is discouraged.
Currently there is nothing similar for runboat

Additional context
Similar to #33.
I ran into this while trying to add https://github.com/OCA/oca-addons-repo-template to https://github.com/OCA/server-tools/tree/10.0 in OCA/server-tools#2486.
There is some discussion already in https://discord.com/channels/737652535149592587/761225067798462465/1067129843130581083

@SirTakobi SirTakobi added the enhancement New feature or request label Jan 24, 2023
@sbidoul
Copy link
Member

sbidoul commented Jan 25, 2023

I'm not sure it's worth the additional complexity. In practice this happens rarely, as more and more projects publish wheels on PyPI.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants