Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

l10n_fr_oca duplicated tax groups #556

Open
sebastienbeau opened this issue Jun 10, 2024 · 1 comment
Open

l10n_fr_oca duplicated tax groups #556

sebastienbeau opened this issue Jun 10, 2024 · 1 comment

Comments

@sebastienbeau
Copy link
Member

Reminder

  • l10n_oca_fr does not depend on l10n_fr
  • l10n_fr_ account_vat_return depends on l10n_fr and l10n_oca_fr

Account tax groups are provided by l10n_fr and l10n_oca_fr so we have duplicated tax groups.

Solution 1:

  • l10n_oca_fr depend on l10n_fr and reuse the tax group of l10n_fr

Solution 2:

  • remove the dependency of l10n_oca_fr in l10n_fr_account_vat_return and move the test of l10n_fr_account_vat_return into a dedicated test module and this module depend on l10n_oca_fr.

Solution 1 seem the only relevant solution, as most of the time both module are always installed

@alexis-via
Copy link
Contributor

TODO : forward port to v16

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants