Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Calling RIP-7212 precompile prints "Calling an account which is not a contract" warning #558

Open
fvictorio opened this issue Jul 18, 2024 · 0 comments

Comments

@fvictorio
Copy link
Member

If enable_rip_7212 is true and you make a call to the 0x100 address where the precompile is, you get "WARNING: Calling an account which is not a contract" printed in the output.

The reason, I think, is this:

let is_precompile = {
let precompiles =
Precompiles::new(precompile::PrecompileSpecId::from_spec_id(spec_id));
precompiles.contains(&to)

I guess we should abstract the "is this a precompile" check somewhere, and use both the spec id and the config to determine this. Or maybe there's a better way to do it.

@fvictorio fvictorio added this to EDR Jul 18, 2024
@github-project-automation github-project-automation bot moved this to Unconfirmed in EDR Jul 18, 2024
@fvictorio fvictorio moved this from Unconfirmed to Todo in EDR Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Todo
Development

No branches or pull requests

1 participant