Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link to code.jquery.com #217

Open
pilot114 opened this issue Aug 10, 2023 · 5 comments
Open

Link to code.jquery.com #217

pilot114 opened this issue Aug 10, 2023 · 5 comments

Comments

@pilot114
Copy link

pilot114 commented Aug 10, 2023

image
Web UI don't work without internet connection (if browser cache is clear)

@NoiseByNorthwest
Copy link
Owner

I'm sorry for that. The next move I will do or accept about JQuery is just dropping it.

@BafS
Copy link
Contributor

BafS commented Jul 19, 2024

Would you accept to inline jquery in the 2 html files as an easy workaround? Our staging environment has to have a specific CSP policy just because of this

@NoiseByNorthwest
Copy link
Owner

Instead of inlining it I prefer using a local snapshot of jquery (.min.js) in order to keep the integrity check (integrity="sha256-hwg4gsxgFZhOsEEamdOYGBf13FyQuiTwlAQgxVSNgt4=")

@NoiseByNorthwest
Copy link
Owner

NoiseByNorthwest commented Jul 20, 2024

I guess

<script src="https://code.jquery.com/jquery-3.2.1.min.js"
        integrity="sha256-hwg4gsxgFZhOsEEamdOYGBf13FyQuiTwlAQgxVSNgt4=" crossorigin="anonymous"></script>

would be replaced by

<script src="js/jquery-3.2.1.min.js"
        integrity="sha256-hwg4gsxgFZhOsEEamdOYGBf13FyQuiTwlAQgxVSNgt4="></script>

@BafS
Copy link
Contributor

BafS commented Jul 22, 2024

Ok, I did a PR to move the external JS to assets: #248

NoiseByNorthwest added a commit that referenced this issue Jul 22, 2024
Move jQuery and jscolor to assets (#217)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants