Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating default lanes fails when there's a book with a language with no name. #819

Open
aslagle opened this issue Jan 17, 2018 · 1 comment

Comments

@aslagle
Copy link
Collaborator

aslagle commented Jan 17, 2018

If you have no languages configured in your library settings and one of the books in your collection has a language that's not in our list, you get an error like this:

Traceback (most recent call last):\n File \“/var/www/circulation/env/local/lib/python2.7/site-packages/flask/app.py\“, line 1612, in full_dispatch_request\n rv = self.dispatch_request()\n File \“/var/www/circulation/env/local/lib/python2.7/site-packages/flask/app.py\“, line 1598, in dispatch_request\n return self.view_functionsrule.endpoint\n File \“/var/www/circulation/api/routes.py\“, line 147, in decorated\n return f(*args, **kwargs)\n File \“/var/www/circulation/api/admin/routes.py\“, line 100, in decorated\n v = f(*args, **kwargs)\n File \“/var/www/circulation/api/admin/routes.py\“, line 79, in decorated\n return f(*args, **kwargs)\n File \“/var/www/circulation/api/admin/routes.py\“, line 94, in decorated\n return f(*args, **kwargs)\n File \“/var/www/circulation/api/admin/routes.py\“, line 493, in reset_lanes\n return app.manager.admin_lanes_controller.reset()\n File \“/var/www/circulation/api/admin/controller.py\“, line 1048, in reset\n create_default_lanes(self._db, flask.request.library)\n File \“/var/www/circulation/api/lanes.py\“, line 120, in create_default_lanes\n _db, library, tiny, priority=priority\n File \“/var/www/circulation/api/lanes.py\“, line 671, in create_lane_for_tiny_collections\n name = LanguageCodes.name_for_languageset(language_set)\n File \“/var/www/circulation/core/util/init.py\“, line 654, in name_for_languageset\n raise ValueError(\“No native or English name for %s\” % l)\nValueError: No native or English name for gaa

@aslagle aslagle changed the title Creating default lanes fails when there's a book with an unrecognized language. Creating default lanes fails when there's a book with a language with no name. Jan 17, 2018
@aslagle
Copy link
Collaborator Author

aslagle commented Jan 17, 2018

Actually in this case the language is in our list, but does not have a name.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant