Based on your definition, a module by itself could not be a plugin? But couldn't a module act as a plugin for execution purposes?

I do like the shorter name and getting plugin into the terminology. I guess I don't think there would be much confusion between module and "module collections", though.

I don't think I have another solution to propose, but I will think about it some more.

@twindus strictly speaking, a "module collection"/"plugin" is a C++ shared library (or Python module) which exposes a load_modules function. Technically that's all PluginPlay cares about, i.e. there can be 0 or more modules in the "module collection"/"plugin" and PluginPlay still recognizes it as a "module collection"/"plugin".

@ryanmrichard Got it! I am fine with the change as long as we document it. Will it cause much ripple through the code?

@twindus I believe it's only an issue in documentation.

Given the overwhelming support for the name change I'm in the process of making the changes in #272. So if anyone has a problem with it now's the time to speak up.

I think module term itself could be a source of confusion since it is overused in programming, i.e. Python modules, C++20 modules etc. How about module -> plugin, module collection -> plugin collection or plugin set?

@keceli while I don't disagree with you, I'm not thrilled with the idea of changing the "module" term at this point given how pervasive it is throughout the stack. Unlike "module collection", changing "module" has code ramifications.

FWIW, in #272 I coined the term "PyModule" to indicate a pluginplay::Module written in Python (to avoid confusion with the usual meaning of a "Python module"). For documentation purposes I think calling them C++/Python pluginplay::Module instances (rather than C++/Python modules) is probably a better solution since, like you pointed out, there's modules in C++ now too.

I like the recent change with 5a8280a in the documentation. Using pluginplay::Module instead of module or PyModule is more clear.

@ryanmrichard @keceli Can this issue be closed? If there are specific actions on this, then we should delineate them.