-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update tests to latest version of gtest #806
Comments
This is resolved in #1035 |
@dguittet can we update Step 4 in the build instructions? https://github.com/NREL/SAM/wiki/Windows-Build-Instructions |
That's tricky - 1035 is going to go into develop for the 2024 release, but the issue will still exist on patch (current develop). Is there a way to cherry-pick the fix to the current branch? |
I think it'll be possible to isolate the fix for patch |
@tyneises I don't think we can change the googletest version until this has been merged though |
In https://github.com/NREL/ssc/runs/6181437239?check_suite_focus=true, the tests failed due to an incompatibility with the latest version of gtest with the following error:
The short term fix was to pin the version of gtest at the last version that worked: #804
This issue covers the long term fix: rewriting our tests to remove the errors.
The text was updated successfully, but these errors were encountered: