Rename CCPP suites to non-meaningful names #477
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d RRFS_v1 to warbler
… to new. Problems that still need solving: - At runtime, there is no logic to map the old suite name to the new for the static API
…ge namelists, documentation, and other stuff later. This helps test back-compatibility features like the alias file. - Update descriptions of "barn_owl" suites, esp details about "prescribed surface" suites - Another set of renames - Add "rename" script for posterity (will delete before commit)
…names). Now we just force everyone to rename them all. We do keep the ability for suite files to be named "suite_[suitename].xml" for back-compatibility. - Update alias files for new names - Rename physics namelists and tracers for renamed suites - Update renames in various files in src and run directory - Update Regression Test files for renames - Remove old, orphaned SDFs SCM_GFS_v15p2_FA and SCM_GFS_v15p2_MYJ Next commit will rename the rest of the suites.
…for each. - Un-delete suite_SCM_GFS_v15p2_MYJ, which is still present in "suite_info.py"
…to treatment of old suites in fv3atm. No reason to waste a bird on these!
- Moved a few more to "suites_not_used" - More specific description for prescribed surface suites
- most importantly, updating the new HR3+RRTMGP (robin) and RRFS_v1 (warbler) suites. - Add some more space in description comments for legibility
…n alias file, correct some rebase mistakes
This reverts commit 9e4f492.
mkavulich
force-pushed
the
feature/suite_names_update_rebase
branch
from
a3061c0
to
fb91098
Compare
mkavulich
force-pushed
the
feature/suite_names_update_rebase
branch
from
5826f71
to
93c292e
Compare
Merged
…e ferrier-aligo microphysics is currently broken
This was referenced Jun 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR renames CCPP suites to non-meaningful bird names, as suggested by various colleagues and ChatGPT. The old names are mapped to the new names via a file "alias.json" for convenience.
Some older, unsupported suites, especially those with no entry in suite_info.py, are moved to a new directory
suites_not_used/, analogous to the ufs-weather-model treatment of these suites.Dependencies:
Framework PR: NCAR/ccpp-framework#569
suite_". This Framework update requires some changes to the CI tests to use MPI, which is required in the latest version.Physics PR: NCAR/ccpp-physics#1073
New guidelines are proposed in CCPP Technical documentation PR here: NCAR/ccpp-doc#72
Tests:
Ran full suite of regression tests, all succeeded. Running manual tests on MacOS showed a few suites that are failing with segmentation faults, but this seems to be intermittent and must be related to my specific machine. One suite (SCM_GFS_v16_RRTMGP "mallard") failed all tests due to memory allocation; this appears to be a pre-existing problem, see #484.
Did a bit-for-bit comparison for all the regtest cases (arm_sgp_summer_1997_A, astex, bomex, LASSO_2016051812, twpice) between this branch and the branch for PR #482 (which updated framework and physics to same hash as this PR); aside from the failing tests the only differences were for suite "robin" (previously SCM_GFS_v17_HR3_RRTMGP), and this is expected due to a changed tracers file.
Issue:
This resolves #476