Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

El Nino and La Nino Hovmoller metric scores shown in all metrics tables and graphics are incorrect, resulting in incorrect Mean Scores. #16

Open
phillips-ad opened this issue May 2, 2023 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@phillips-ad
Copy link
Collaborator

Pattern correlations and rms difference values for El Nino and La Nino Hovmollers shown in metrics tables and metrics graphics are incorrect, resulting in the Mean Scores also being incorrect. A bug in the metrics code was incorrectly restricting the longitudes that these metrics were calculated over. The fix is relatively simple.
In ncl_scripts/metrics.ncl simply remove all instances of the following code: "(:,24:54)". The line numbers where this code is found are lines 186, 295, 296, 353 and 354 of ncl_scripts/metrics.ncl.

Pattern correlations shown in the lower right hand side of individual and summary El Nino and La Nina Hovmoller plots are correct.

@phillips-ad phillips-ad added the bug Something isn't working label May 2, 2023
@phillips-ad phillips-ad self-assigned this May 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant