Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

noncontig passthrough #299

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

noncontig passthrough #299

wants to merge 1 commit into from

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Nov 11, 2022

Description

Tentative allowing noncontiguous fragment input in Molecule with validation. Partially fixes #298.

Background is that Mol can store noncontig fragments. However, the internals that the validation step uses can't store them; it can either balk or reorder the atoms so the fragments are contiguous. This PR makes the latter option accessible through the Mol constructor.

This option should be used tentatively and with results checking at first. Note that identical atom ordering is not assured with allow_noncontiguous_but_reorder=T between validate=T/F. Those wanting validation and atom order presevation may want to Molecule(..., allow_noncontiguous_but_reorder=True), and if that passes, use the results from mol = Molecule(..., validate=False).

This is not a permanent solution, and a future solution with some sort of fix_order (like fix_com; remember, "affix", not "correct") will use a different option, since reordering that is unnecessary for the schema spec is not good.

Changelog description

Status

  • Code base linted
  • Ready to go

@codecov
Copy link

codecov bot commented Nov 11, 2022

Codecov Report

Merging #299 (0cc6ee9) into master (292350f) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Additional details and impacted files

@awvwgk
Copy link
Contributor

awvwgk commented Jan 15, 2024

Anything blocking this from getting merged?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup qcel.models.Molecule with non-contiguous fragments
2 participants