Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Tentative allowing noncontiguous fragment input in Molecule with validation. Partially fixes #298.
Background is that Mol can store noncontig fragments. However, the internals that the validation step uses can't store them; it can either balk or reorder the atoms so the fragments are contiguous. This PR makes the latter option accessible through the Mol constructor.
This option should be used tentatively and with results checking at first. Note that identical atom ordering is not assured with
allow_noncontiguous_but_reorder=T
betweenvalidate=T/F
. Those wanting validation and atom order presevation may want toMolecule(..., allow_noncontiguous_but_reorder=True)
, and if that passes, use the results frommol = Molecule(..., validate=False)
.This is not a permanent solution, and a future solution with some sort of
fix_order
(likefix_com
; remember, "affix", not "correct") will use a different option, since reordering that is unnecessary for the schema spec is not good.Changelog description
Status