Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add variable distribution to partial dependence plots #390

Open
RoyalTS opened this issue Feb 22, 2021 · 2 comments
Open

add variable distribution to partial dependence plots #390

RoyalTS opened this issue Feb 22, 2021 · 2 comments
Labels
feature 💡 New feature or enhancement request long term 📆 TODO long term Python 🐍 Related to Python

Comments

@RoyalTS
Copy link
Contributor

RoyalTS commented Feb 22, 2021

... as produced by model_profile either by marking off variable deciles at the bottom of each plot the way sklearn does it e.g. (https://scikit-learn.org/stable/auto_examples/inspection/plot_partial_dependence.html) or by including an entire histogram (example: https://towardsdatascience.com/prettifying-partial-density-plots-in-python-1f7216937ff).

@hbaniecki hbaniecki added feature 💡 New feature or enhancement request Python 🐍 Related to Python labels Feb 22, 2021
@hbaniecki
Copy link
Member

(Note to self) I would like to add this feature into dalex but the AggregatedProfiles explanation object has no information about the data attribute from Explainer. I am unsure whether we want to copy the dataset into an explanation object. A more effective approach would require e.g. computing histograms for all the variables during the model_profile initialization.

@hbaniecki hbaniecki added the long term 📆 TODO long term label Sep 9, 2021
@pbiecek
Copy link
Member

pbiecek commented Jan 15, 2022

@hbaniecki is it feasible (possible with a new function that will get the data as additional argument)?
if not then let's close this issue with suitable comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature 💡 New feature or enhancement request long term 📆 TODO long term Python 🐍 Related to Python
Projects
None yet
Development

No branches or pull requests

3 participants