Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Another potential issue for integer overflow #40

Open
waooog opened this issue Aug 15, 2017 · 0 comments
Open

Another potential issue for integer overflow #40

waooog opened this issue Aug 15, 2017 · 0 comments

Comments

@waooog
Copy link

waooog commented Aug 15, 2017

Hi,

Our tool found the following suspicious code in:
src/org/swiftp/CmdNLST.java

In Line 35:
public final static long MS_IN_SIX_MONTHS = 6 * 30 * 24 * 60 * 60 * 1000;

Could this be as follow to avoid integer overflow?:

public final static long MS_IN_SIX_MONTHS = 6 * 30 * 24 * 60 * 60 * 1000L;

This might be a trivial thing but I wanted to report just in case.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant