Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: "create-update-issues" workflow skips pre-1.0 breaking changes #4904

Open
Gudahtt opened this issue Nov 7, 2024 · 1 comment
Open

ci: "create-update-issues" workflow skips pre-1.0 breaking changes #4904

Gudahtt opened this issue Nov 7, 2024 · 1 comment
Labels
bug Something isn't working team-wallet-framework

Comments

@Gudahtt
Copy link
Member

Gudahtt commented Nov 7, 2024

The create-update-issues workflow is intended to create issues in extension and mobile for updating controllers after a breaking change. However, it currently only looks for major version bumps. Breaking changes to controllers that are pre-1.0 are not considered.

We should update the workflow to create issues for breaking changes in pre-1.0 controllers as well. i.e. when the major version is zero, a minor bump should be considered breaking and trigger the creation of issues.

Note that technically according to SemVer, any pre-1.0 release can be breaking, even patch releases. But it's conventional for many package authors (and on our team) that pre-1.0 breaking changes be released as a minor version bump (and this is how the ^ operator works, see here for more details), so that's what this workflow will assume.

@Gudahtt Gudahtt added the bug Something isn't working label Nov 7, 2024
@Gudahtt Gudahtt changed the title "create-update-issues" workflow skips pre-1.0 breaking changes ci: "create-update-issues" workflow skips pre-1.0 breaking changes Nov 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working team-wallet-framework
Projects
None yet
Development

No branches or pull requests

2 participants
@Gudahtt and others