Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FreeBSD etc #2

Open
JamesMolson opened this issue Jan 23, 2017 · 10 comments
Open

FreeBSD etc #2

JamesMolson opened this issue Jan 23, 2017 · 10 comments

Comments

@JamesMolson
Copy link
Collaborator

maybe extract the version from freebsd-version or from uname -r ?

@JamesMolson
Copy link
Collaborator Author

Or do the better thing, https://cmake.org/Wiki/CMake_Useful_Variables

CMAKE_SYSTEM 
    the complete system name, e.g. "Linux-2.4.22", "FreeBSD-5.4-RELEASE" or "Windows 5.1" 
CMAKE_SYSTEM_NAME 
    the short system name, e.g. "Linux", "FreeBSD" or "Windows" 

@JamesMolson
Copy link
Collaborator Author

elseif (${PLATFORM} MATCHES "FreeBSD")
	set ( PLATFORM ${CMAKE_SYSTEM})
endif()

is sufficient

@Sam-Tygier
Copy link
Contributor

Could you confirm that commit ebf85c3 works on freebsd

For linux I think it is good to still have distro checking code, rather than just using CMAKE_SYSTEM

@JamesMolson
Copy link
Collaborator Author

@JamesMolson
Copy link
Collaborator Author

Well, some tests do fail, but the script runs :)

@JamesMolson
Copy link
Collaborator Author

Though:

-- The C compiler identification is Clang 3.8.0
-- The CXX compiler identification is Clang 3.8.0

And the script has reported it as gcc 4.9.4 which wasn't used.

@Sam-Tygier
Copy link
Contributor

The bit in the reported string comes from the output of running ${CMAKE_CXX_COMPILER} --version
Looks to me like cmake is ignoring that and using the default compiler anyway.

So you could put set(CMAKE_CXX_COMPILER "clang") and get the version sting right. But it would keep using clang, no matter what the variable is set too.

@Sam-Tygier
Copy link
Contributor

Looks like it just needed to be passed across 1a71878

@Sam-Tygier
Copy link
Contributor

and of course it should be
set(CMAKE_CXX_COMPILER "clang++")

@JamesMolson
Copy link
Collaborator Author

Build name: FreeBSD-11.0-RELEASE-p2 amd64 clang++ 3.8.0 (Release)

That is better.

Also the cdash box is out of disk space now :p

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants