Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Opening canvas in second window does not lock canvas #1

Open
mariomui opened this issue Sep 6, 2023 · 4 comments
Open

Bug: Opening canvas in second window does not lock canvas #1

mariomui opened this issue Sep 6, 2023 · 4 comments
Assignees
Labels
bug Something isn't working help wanted Extra attention is needed

Comments

@mariomui
Copy link

mariomui commented Sep 6, 2023

Summary

As a stacked tabs user, when i open the canvas in its own window via Second Window Plugin1
, the zoomLock property is not patched on the new window.

  • Procedure:
    • User moves canvas to a new tab view Second Window Feature
  • Expected:
    • Scrolling is locked
  • Actual:
    • Scrolling is not locked

Proposed Solution:

Apply the monkey around to the respective canvases (for all windows) by using the window-open event.

Challenges

  • Auto disabling zoom may be unwise when opening a second window since the window would be "Big" by default.
  • The number of people using Second Window and Stacked Tabs may be a small fraction of users.

Corrections

"move current tab to new window" may be a built-in feature of obsidian and not a feature of second window. 1

@Mara-Li
Copy link
Owner

Mara-Li commented Sep 6, 2023

Hmm, strangly, I don't reproduce the bug on my side…

@Mara-Li Mara-Li self-assigned this Sep 6, 2023
@Mara-Li Mara-Li added bug Something isn't working help wanted Extra attention is needed labels Sep 6, 2023
@mariomui
Copy link
Author

mariomui commented Sep 6, 2023

Hmm, strangly, I don't reproduce the bug on my side…

Are you a stacked tabs user?
i have also installed it with BRAT. i will try it via compiling and get back to you.

@Mara-Li
Copy link
Owner

Mara-Li commented Sep 6, 2023

Nop, using tab the normal way. Can't repro :/

@mariomui
Copy link
Author

mariomui commented Sep 7, 2023

i'll make a video tomorrow and specify my procedure.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

2 participants