Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT, TST: no_deprecated_call modernization #4746

Open
tylerjereddy opened this issue Oct 20, 2024 · 1 comment · May be fixed by #4747
Open

MAINT, TST: no_deprecated_call modernization #4746

tylerjereddy opened this issue Oct 20, 2024 · 1 comment · May be fixed by #4747

Comments

@tylerjereddy
Copy link
Member

tylerjereddy commented Oct 20, 2024

As detailed at #4744 (comment), no_deprecated_call (an old MDA testing utility) now requires an explicit warning class specification to work--so it'll choke with warnings.warn("boo"), but succeed with warnings.warn("boo", UserWarning).

Should probably be fixed (and or/upstreamed to pytest or put in some pytest plugin perhaps).

It is still actively used in our suite, but only a little bit, and perhaps not enough to have tracked the increased complexity of the warnings system from Python 2->3.

@lilyminium
Copy link
Member

lilyminium commented Oct 20, 2024

Good point on trade-offs here -- IMO since it is actively used in our test suite (and would love to use it in the scenario of #4744, although it probably will have to happen after 2.8.0), we should maintain it. Between the last change 7 years ago the only difference seems to be that the default behaviour seems to have changed, so IMO the maintennace cost isn't extreme. I opened #4747 to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants