Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing object offsets storage? #239

Open
Luke-Poeppel opened this issue Jul 23, 2021 · 0 comments
Open

Removing object offsets storage? #239

Luke-Poeppel opened this issue Jul 23, 2021 · 0 comments
Assignees
Labels
breaking Breaking change Improvement Improvement to speed or code complexity invalid This doesn't seem right

Comments

@Luke-Poeppel
Copy link
Owner

When I first started writing get_object_indices, I stored both the extracted objects and the (offset, offset+quarterLength) pair. But this is pretty silly... It's stored in the object anyway! It is slightly more safe because of the contiguous summation stuff, but if I'm appropriately deepcopying it, it really shouldn't be necessary. Moreover, removing the lists consequently removes all the confusing obj[1][0], obj[-1][1] stuff.

@Luke-Poeppel Luke-Poeppel added enhancement New feature or request invalid This doesn't seem right Improvement Improvement to speed or code complexity labels Jul 23, 2021
@Luke-Poeppel Luke-Poeppel self-assigned this Jul 23, 2021
@Luke-Poeppel Luke-Poeppel added breaking Breaking change and removed enhancement New feature or request labels Aug 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
breaking Breaking change Improvement Improvement to speed or code complexity invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

1 participant