Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kanban board Project detail #21

Open
IfzaRasool opened this issue Apr 11, 2022 · 3 comments
Open

Kanban board Project detail #21

IfzaRasool opened this issue Apr 11, 2022 · 3 comments

Comments

@IfzaRasool
Copy link
Collaborator

@t-yanick
Copy link

t-yanick commented Apr 11, 2022

Hi Team,

Good job so far!
There are some issues that you still need to work on to go to the next project but you are almost there!

Required Changes ♻️

Check the comments below under the review.

Please kindly update your kanban board with the following changes

  • Please make sure all cards are assigned to team members and should be assigned in a fair way. That is; you need to decide who is Student A, Student B. So each card with Student A in its title should always be assigned to the same student (and analogical for other students). All cards with group task in the title should be assigned to someone (it does not matter to whom).

Optional suggestions

Every comment with the [OPTIONAL] prefix is not crucial enough to stop the approval of this PR. However, I strongly recommend you to take them into account as they can make your code better.

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification.

Please, do not open a new Pull Request for re-reviews. You should use the same Pull Request submitted for the first review, either valid or invalid unless it is requested otherwise.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

@LionRouge1
Copy link
Owner

Hi @t-yanick 👋
First of all, thank you for the review 🙏. All your requirements have been taken into consideration and changes had been made according to them. But we left some cards with group task in the title because we think we will do them in a group

@prolajumokeoni
Copy link

Hi @Team,
Your project is complete! There is nothing else to say other than... it's time to merge it :shipit:
Congratulations! 🎉

Cheers and Happy coding!👏👏👏

Feel free to leave any questions or comments in the PR thread if something is not 100% clear.
Please, remember to tag me in your question so I can receive the notification @prolajumokeoni.


As described in the Code reviews limits policy you have a limited number of reviews per project (check the exact number in your Dashboard). If you think that the code review was not fair, you can request a second opinion using this form.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants