-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor: Separate SCSS files to reduce index page content #25
Comments
I have created a PR for this #26, let me know if you agree with this! Thanks |
Hi @adolfogustavo! Thanks for working on this issue. Instead of creating multiple .scss files, we should create new single file .vue components with the scoped attribute. As a starting point we can create the sidebar and output components, and keep the general styles in the default.vue file. |
Hi @acapeletto - Thanks for answering! Do you want to create those sidebar.vue
If so, I think it is still a good idea to have multiple .scss files to have shorter and more organized files (That's why I proposed the issue in the first place) What I wanted with my approach was to start uncoupling the styles before separating/re-composing the current What do you think? I'm open to suggestions. |
Hi guys, I believe the best approach for this in vue is to have the CSS inside the If the files are still too long, maybe we should create simpler components to shorten up those |
Good suggestion, I'll deep a little bit more into that and update the PR accordingly - thanks |
Also, @apresmoi could u assign me this issue? Thanks! |
Assigned! |
Hi folks - As an initial effort to start reducing so many lines of code in the
index.vue
file, a good practice is to start creating separate folders for the styles, each identified with the content that they impact within the app, this will also give better clarity at the time of reading the code for future contributors.Based on what we have currently, I propose to have this easy-to-read/edit distribution:
The text was updated successfully, but these errors were encountered: