Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to whitelist a Factory created contract #215

Open
georgeciubotaru opened this issue Aug 13, 2024 · 0 comments
Open

Need to whitelist a Factory created contract #215

georgeciubotaru opened this issue Aug 13, 2024 · 0 comments

Comments

@georgeciubotaru
Copy link

georgeciubotaru commented Aug 13, 2024

Planning to integrate the Clearpool Finance protocol apps into the Ledger, but having some issues.

Scope: Implement Clear Signing for whitelisting Clearpool contracts interactions with Ledger.

  1. We have Factory and dynamically created contract Pools, what is the flow to add them?
    Should we add manually one by one and repeat for each of them the abi file?

  2. Based on the structure we should define the abis folder, b2c and eip712 files, where should we declare this structure https://github.com/LedgerHQ/clear-signing-format-spec/blob/master/spec.md ?

  3. We are supporting most of the networks from the list, is it okay to have 1 PR per network, or somehow to validate the correct structure with 1 network, before proceeding with the others?

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant